search

Automattic / simplenote-android

Simplenote for Android
https://simplenote.com
GNU General Public License v2.0
1.79k stars 301 forks source link

Extract create backmerge PR methods in helper files #1698

Closed mokagio closed 1 month ago

mokagio commented 2 months ago

Fix

What it says in the title. This is a followup to the discussion with @iangmaia here: https://github.com/Automattic/simplenote-android/pull/1695#discussion_r1766314653

Test

This is tricky to test outside the release cycle. I checked out a test branch, added a lane that calls the method and saw it go through the expected steps, which was enough to verify everything is at least wired in a way that Ruby can interpret.

image

image

Review

Only one infra engineer required to review these changes, but anyone can perform the review.

Release

These changes do not require release notes.

wpmobilebot commented 2 months ago

📲 You can test the changes from this Pull Request in Simplenote Android by scanning the QR code below to install the corresponding build.

App Name Simplenote Android
Build TypeDebug
Commit6efc4c5e9a106566609ed6b1109e8793081a2d14
Direct Downloadsimplenote-android-prototype-build-pr1698-6efc4c5-019227ec-5cba-44e9-bc77-db06ce1aff69.apk