Automattic / simplenote-android

Simplenote for Android
https://simplenote.com
GNU General Public License v2.0
1.79k stars 301 forks source link

Trigger release build instead of running it in `finalize_release` #1710

Closed mokagio closed 1 month ago

mokagio commented 1 month ago

Two reasons:

  1. In it's current status if fails because of tumblr-metal constraints. See https://buildkite.com/automattic/simplenote-android/builds/433#0192c195-15a6-49dd-be04-e14b04eea312
  2. There is a difference from simply running the lane that builds the release build and running the full CI pipeline. The latter is what we need.

Will merge without waiting for CI because none of the code changed here runs in the standard CI. We'll validate it once in the release branch by running a new release finalization attempt.

dangermattic commented 1 month ago
1 Error
:no_entry_sign: PR requires at least one label.
1 Warning
:warning: PR is not assigned to a milestone.

Generated by :no_entry_sign: Danger

wpmobilebot commented 1 month ago

📲 You can test the changes from this Pull Request in Simplenote Android by scanning the QR code below to install the corresponding build.

App Name Simplenote Android
Build TypeDebug
Commit3398e0ffe4272c13ce3dfd0111839fbc2728eb90
Direct Downloadsimplenote-android-prototype-build-pr1710-3398e0f-0192c19f-a786-40ed-9856-68a9121c4f35.apk