Automattic / simplenote-android

Simplenote for Android
https://simplenote.com
GNU General Public License v2.0
1.79k stars 301 forks source link

Checklists: Checkboxes aren't formatted in markdown preview #872

Open rachelmcr opened 5 years ago

rachelmcr commented 5 years ago

Expected

I expect checkboxes to appear as checkboxes in the markdown preview of a note.

Observed

Checkboxes look fine in the editor, but in the markdown preview they look like this:

• [ ] one
• [ ] two
• [ ] three

Reproduced

  1. Create a new markdown note.
  2. Add checklist items to the note.
  3. Switch to the note preview.

In the editor:

In the preview:

Make Model Android Version App Version
Motorola moto e5 play 8.1.0 2.2
Redmi Note 7 9 2.2

Original report from a public beta tester and I reproduced the issue.

theck13 commented 5 years ago

This has been a known issue since checklists were introduced*. It's a non-trivial amount of work and may require a new parser as shown in https://github.com/Automattic/simplenote-android/pull/628.

marianoju commented 4 years ago

This issue makes checklists unusable for me.

iskandergaba commented 4 years ago

Maybe it is too complicated to make a perfect preview, but it is possible to make it look much better using \u2610 and \u2611 unicode symbols for checked and unchecked boxes, respectively, in the preview tab. This could serve as a solution for the mean time until perhaps a new parser is used.

Needless to say, these symbols are only used in the preview tab and do not affect the search mechanism where searching [x] should return notes with checkboxes. I tested it.

If you think this is good as a temporary solution, I will make a PR with these changes.

Update: This small tweak works well even with the RTL fix I implemented in #1075. What do you think @theck13?

Here's a screenshot of how would this look like. Screenshot

marianoju commented 4 years ago

Any development (as in: progress) of this issue would be welcome.

reginabally commented 4 years ago

Another report in 3535160-zen.

reginabally commented 3 years ago

New report in 3688245-zen which was originally from a Google Play Store app review. I will share with the user the limitation of the parser.

eduardozulian commented 3 years ago

Another report in 4087236-zen

danilo04 commented 3 years ago

Another report: #1492.

erricgunawan commented 2 years ago

Another report from 4727183-zen:

The device is a Samsung A72, it is running One UI version 3.1 and Android 11. The version of the app currently is 2.23 Screenshots of the "issue" The first and more important thing is that is not consistent:

Above are 2 examples of how markdown previews should look like. The to-dos are clickable to check or uncheck a task. In the second image, you see a line as a divider. Now see how the preview works in the app:

There is no line divider, instead that 3 dot thing. And the check buttons, well, are not buttons at all, I can only interact with them if I go to edit. And also, notice how in the web version, I only click a button and I enter in preview mode, and all my notes that have markdown activated, I see them in that mode. In the mobile app, if I want to see my notes in preview, I have to slide individually in each of them. All this things are not bugs, but rather decisions and how that part of markdown works, and I suppose there is a reason for that, but I must say this is the only service I know that supports markdown and does it this way. But I believe that if in the web you did the right way, you can also agree that´s the way I should be done

(I didn't include the screenshots since they might contain private info).

erricgunawan commented 2 months ago

Another report: 8706021-zen

azollafox commented 2 months ago

Another report https://forums.simplenote.com/forums/topic/bug-in-android-checklists/?view=all#post-3262