Closed mokagio closed 1 week ago
Requested an @Automattic/apps-infrastructure review for feedback on the npm
approach.
@codebykat the head is release/2.22.0
because I'm wishfully hoping to port the rest of the setup before it's time to cut the final build. At worst, we'll ship 2.22.0 on the old infra and continue the upgrade later.
Superseded by #3204
Moves the lint and unit tests CI steps from CircleCI to Buildkite.
It uses an experimental approach to
npm
that:npm ci
instead ofnpm install
, as recommended for CI jobsnpm ci
, which recreatesnode_modules
, only caches the NPM cache.I'm a bit unsure about the approach to be honest. Is the cache gate necessary? What are the chances of race condition? Besides, the performance of using vs not using the cache with
npm ci
do not seem to be that different, which makes me question whether it's worth having in the first place.Keen to hear what you think. I'd still propose to merge as is and see how it behaves. This investigation has a broader scope that just this project, as we have new Electron apps that might use this new approach.
Test
See green CI.
Release
N.A.