search

Automattic / simplenote-electron

Simplenote for Web, Windows, and Linux
https://app.simplenote.com
GNU General Public License v2.0
4.69k stars 553 forks source link

Exploration on the "can't resolve buffer" error #3209

Closed mokagio closed 1 month ago

mokagio commented 1 month ago

2bf1dd662b5134bc0c8d3d4d508406ab32a27773 shows that using --force instead of --legacy-peer-deps doesn't result in the failure in CI.

But why is the failure not occurring locally when using --legacy-peer-deps?

40b4250c74926e0c34da2edff9779928f1cbe321 and a6282429 are to verify whether the react-monaco-editor update, which if I remember well was the reason for using the legacy deps flag, solves the issue.

Still to answer: why is the failure not occurring locally when using --legacy-peer-deps??

mokagio commented 1 month ago

Closing after establishing that @codebykat fix in a6613931fea70001bd2a7db60f590fb2635c90c7 addresses the issue.

Still to answer why CircleCI and Buildkite see this, but local builds do not