Automattic / simplenote-electron

Simplenote for Web, Windows, and Linux
https://app.simplenote.com
GNU General Public License v2.0
4.69k stars 553 forks source link

`make` `build-if-not-exists` and `build-if-changed` always build #3211

Open mokagio opened 1 month ago

mokagio commented 1 month ago

That's because they look for dist/app.js but webpack uses fullhash in the name, i.e. dist/app.20fd562f4b5b27e29042.js

https://github.com/Automattic/simplenote-electron/blob/f5d463f7a5f5beb3638696c9700b1c7781448744/Makefile#L21

https://github.com/Automattic/simplenote-electron/blob/f5d463f7a5f5beb3638696c9700b1c7781448744/webpack.config.js#L23

mokagio commented 1 week ago

That's because they look for dist/app.js but webpack uses fullhash in the name

This behavior was introduced in https://github.com/Automattic/simplenote-electron/pull/1543

codebykat commented 1 week ago

Right, I don't think we want to revert the hash, rather improve the Makefile detection... I tinkered with it a bit in #3225 but I'm not sure if that helps or not.