If you "check for updates" on a non-packaged version of the app, it will immediately resolve the promise to null and log the message "Skip checkForUpdates because application is not packed and dev update config is not forced". However the current progress bar doesn't get an onError callback from that so it hangs indefinitely.
This PR uses the same function the updater uses to disable the option to check for updates if it won't work anyway.
Fixes #3213 (the underlying problem isn't what I initially thought it was)
Test
On a packaged version of the app (see build artifacts), you should be able to check for updates from the menu
On a development version (e.g. from npm run dev), the menu option should be grayed out
Release
Disable the menu item to check for updates in the development environment
Fix
If you "check for updates" on a non-packaged version of the app, it will immediately resolve the promise to
nulland log the message "Skip checkForUpdates because application is not packed and dev update config is not forced". However the current progress bar doesn't get anonErrorcallback from that so it hangs indefinitely.This PR uses the same function the updater uses to disable the option to check for updates if it won't work anyway.
Fixes #3213 (the underlying problem isn't what I initially thought it was)
Test
npm run dev), the menu option should be grayed outRelease
Disable the menu item to check for updates in the development environment