Closed roundhill closed 4 months ago
Buildkite artifact testing:
On both macOS and Windows I tested that I could log in (to further ensure that the config contained the proper keys).
Did you find any info on why that fallback doesn't work? Do I have a different version of webpack installed or something?
No I'm not sure either, but it also seems that you can't have a require
with a bad path anywhere in the code, as webpack needs to look for all of the required files to do its compression with.
Closing in favor of #3232
Fix
This fixes #3228. It does not appear possible to do dynamic requires in webpack, so instead I'm proposing the app use an
app-config.json
file that gets created in the webpack build, using either the contents ofconfig-local.json
if it is present, otherwise it will useconfig.json
usingfs
to detect if the file is present or not.Test
npm run dev
app-config.json
file was created properly. (Try deleting yourconfig-local.json
file if present, it should update to whatever is inconfig.json
)