Automattic / simplenote-electron

Simplenote for Web, Windows, and Linux
https://app.simplenote.com
GNU General Public License v2.0
4.83k stars 559 forks source link

New patch release to test updater fixes #3234

Closed mokagio closed 2 months ago

mokagio commented 4 months ago

So I added zip to the macOS config and shipped 2.22.2-beta.1 but I'm getting an odd error when checking for updates:

[2024-07-19 19:36:42.855] [desktop:updater] [error] Update error Cannot find latest-mac.yml in the latest release artifacts (https://github.com/Automattic/simplenote-electron/releases/download/v2.22.2-beta.2/latest-mac.yml): HttpError: 404 
"method: GET url: https://github.com/Automattic/simplenote-electron/releases/download/v2.22.2-beta.2/latest-mac.yml\n\nPlease double check that your authentication token is correct. Due to security reasons, actual status maybe not reported, but 404.\n"
Headers: {
  "cache-control": "no-cache",
  "content-encoding": "gzip",
  "content-length": "29",
  "content-security-policy": "default-src 'none'; base-uri 'self'; connect-src 'self'; form-action 'self'; img-src 'self' data:; script-src 'self'; style-src 'unsafe-inline'",
  "content-type": "text/plain; charset=utf-8",
  "date": "Fri, 19 Jul 2024 09:36:42 GMT",
  "referrer-policy": "no-referrer-when-downgrade",
  "server": "GitHub.com",
  "strict-transport-security": "max-age=31536000; includeSubdomains; preload",
  "vary": "X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, Accept-Encoding, Accept, X-Requested-With",
  "x-content-type-options": "nosniff",
  "x-frame-options": "deny",
  "x-github-request-id": "FAF2:3B94D6:13661F7:1581BE8:669A33AA",
  "x-xss-protection": "0"
}
    at createHttpError (/Applications/Simplenote.app/Contents/Resources/app-arm64.asar/node_modules/electron-updater/node_modules/builder-util-runtime/out/httpExecutor.js:21:12)
    at ElectronHttpExecutor.handleResponse (/Applications/Simplenote.app/Contents/Resources/app-arm64.asar/node_modules/electron-updater/node_modules/builder-util-runtime/out/httpExecutor.js:121:20)
    at ClientRequest.<anonymous> (/Applications/Simplenote.app/Contents/Resources/app-arm64.asar/node_modules/electron-updater/node_modules/builder-util-runtime/out/httpExecutor.js:87:26)
    at ClientRequest.emit (node:events:518:28)
    at SimpleURLLoaderWrapper.<anonymous> (node:electron/js2c/browser_init:2:114121)
    at SimpleURLLoaderWrapper.emit (node:events:518:28){"code":"ERR_UPDATER_CHANNEL_FILE_NOT_FOUND"}
Error: Cannot find latest-mac.yml in the latest release artifacts (https://github.com/Automattic/simplenote-electron/releases/download/v2.22.2-beta.2/latest-mac.yml): HttpError: 404 
"method: GET url: https://github.com/Automattic/simplenote-electron/releases/download/v2.22.2-beta.2/latest-mac.yml\n\nPlease double check that your authentication token is correct. Due to security reasons, actual status maybe not reported, but 404.\n"
Headers: {
  "cache-control": "no-cache",
  "content-encoding": "gzip",
  "content-length": "29",
  "content-security-policy": "default-src 'none'; base-uri 'self'; connect-src 'self'; form-action 'self'; img-src 'self' data:; script-src 'self'; style-src 'unsafe-inline'",
  "content-type": "text/plain; charset=utf-8",
  "date": "Fri, 19 Jul 2024 09:36:42 GMT",
  "referrer-policy": "no-referrer-when-downgrade",
  "server": "GitHub.com",
  "strict-transport-security": "max-age=31536000; includeSubdomains; preload",
  "vary": "X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, Accept-Encoding, Accept, X-Requested-With",
  "x-content-type-options": "nosniff",
  "x-frame-options": "deny",
  "x-github-request-id": "FAF2:3B94D6:13661F7:1581BE8:669A33AA",
  "x-xss-protection": "0"
}
    at createHttpError (/Applications/Simplenote.app/Contents/Resources/app-arm64.asar/node_modules/electron-updater/node_modules/builder-util-runtime/out/httpExecutor.js:21:12)
    at ElectronHttpExecutor.handleResponse (/Applications/Simplenote.app/Contents/Resources/app-arm64.asar/node_modules/electron-updater/node_modules/builder-util-runtime/out/httpExecutor.js:121:20)
    at ClientRequest.<anonymous> (/Applications/Simplenote.app/Contents/Resources/app-arm64.asar/node_modules/electron-updater/node_modules/builder-util-runtime/out/httpExecutor.js:87:26)
    at ClientRequest.emit (node:events:518:28)
    at SimpleURLLoaderWrapper.<anonymous> (node:electron/js2c/browser_init:2:114121)
    at SimpleURLLoaderWrapper.emit (node:events:518:28)
    at newError (/Applications/Simplenote.app/Contents/Resources/app-arm64.asar/node_modules/electron-updater/node_modules/builder-util-runtime/out/error.js:5:19)
    at fetchData (/Applications/Simplenote.app/Contents/Resources/app-arm64.asar/node_modules/electron-updater/out/providers/GitHubProvider.js:109:63)
    at async GitHubProvider.getLatestVersion (/Applications/Simplenote.app/Contents/Resources/app-arm64.asar/node_modules/electron-updater/out/providers/GitHubProvider.js:121:27)
    at async MacUpdater.getUpdateInfoAndProvider (/Applications/Simplenote.app/Contents/Resources/app-arm64.asar/node_modules/electron-updater/out/AppUpdater.js:342:19)
    at async MacUpdater.doCheckForUpdates (/Applications/Simplenote.app/Contents/Resources/app-arm64.asar/node_modules/electron-updater/out/AppUpdater.js:356:24)

No surprise the URL 404s, considering it's looking for 2.22.2-beta.2 which does not exist.

I can see how it might check the next version but why fail when it's not there? Isn't that a sign that we're on the latest?

mokagio commented 4 months ago

Also, opened https://github.com/Automattic/simplenote-electron/pull/3235 to investigate the Windows issues further.

mokagio commented 4 months ago

Trying to upgrade from 2.22.2-beta.1 to 2.22.2-beta.2 gives

Screenshot 2024-07-19 at 8 09 16 PM

And I then that leaves the download progress blocked.

Screenshot 2024-07-19 at 8 10 17 PM