search

Automattic / simplenote-electron

Simplenote for Web, Windows, and Linux
https://app.simplenote.com
GNU General Public License v2.0
4.78k stars 557 forks source link

Remove `gconf2` dependency #3244

Closed mokagio closed 1 month ago

mokagio commented 1 month ago

Fix

This is an attempt to fix the issue reported by users who cannot install Simplenote on various Linux systems because the gconf2 dependency cannot be satisfied, https://github.com/Automattic/simplenote-electron/issues/3241

The electron-builder docs mention that gconf2 can give issues if one wants to support KDE.

If need to support KDE, gconf2 and gconf-service should be removed as it’s no longer used by GNOME.

Moreover, the gconf2 entry in the Debian packages repository states:

This package is for legacy applications and no longer used by GNOME.

Given the above, this PR is an attempt to see what the app would do without the dependency. My guess is that everything should run fine in most modern systems, because all information points to gconf2 not being in use there.

Test

To test this we'll need to download the artifacts from CI and try to install them on Linux distros. If it works on our end, it might be good to reach out to the users in #3241 and see how they go.

mokagio commented 1 month ago

All the Linux binaries have been built, which is already a good sign. I didn't have the time to set up VMs, but I plan to do so next week.

In the meantime pinging @codebykat and @roundhill in case you have access and bandwidth.

codebykat commented 1 month ago

This got lost in the Slack backlog, noting @roundhill was able to successfully test this on Fedora in an arm64 VM.

codebykat commented 1 month ago

Hmm. We can't share the build artifacts from Buildkite, they require a login. I'm going to merge this in hopes of getting a testable beta.

mokagio commented 1 month ago

I'm going to merge this in hopes of getting a testable beta.

👍