search

Automattic / simplenote-electron

Simplenote for Web, Windows, and Linux
https://app.simplenote.com
GNU General Public License v2.0
4.78k stars 557 forks source link

Add Magic link login #3246

Closed codebykat closed 1 month ago

codebykat commented 1 month ago

Fix

Adds the option to login via a link or code to the Electron apps.

Screenshot 2024-08-27 at 12 17 37 PM Screenshot 2024-08-27 at 12 20 00 PM

Test

  1. You should download a build from this PR to test with. (In the build artifacts)
  2. Enter a valid account email.
  3. You should get the code or link via email
  4. Entering the code should work (Clicking the link was tested on the GAE PR already)
  5. Try ALL the other things on the sign in form: password entry, creating an account, etc. Should still work!

Release

Added the option to log in via "magic" link or code.

roundhill commented 1 month ago

We might need to make sure we're sending Access-Control-Allow-Origin from the new endpoints?

roundhill commented 1 month ago

⚠️ Code text field isn't the first responder

All sorted! Thanks @jleandroperez