Automattic / simplenote-ios

Simplenote for iOS
https://simplenote.com
GNU General Public License v2.0
2.02k stars 281 forks source link

Updated rake file to fix bundle install --path depreciation #1559

Closed charliescheer closed 1 month ago

charliescheer commented 1 month ago

Fix

While working on SNiOS I noticed that bundle has depreciated using --path when invoking commands and suggests setting a config path value instead.

[DEPRECATED] The `--path` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set --local path 'vendor/bundle'`, and stop using this flag

In this PR I have updated the rake file to fix this depreciation

Test

  1. The bundle commands only run and show anything if it has to do work, so in terminal go to the SNiOS folder and type bundle exec gem uninstall nokogiri 1.15.4. Hit yes a couple of times to remove this gem
  2. type rake dependencies
  3. confirm that bundler runs without any depreciation notices

Review

(Required) Add instructions for reviewers. For example:

Only one developer is required to review these changes, but anyone can perform the review.

Release

These changes do not require release notes.