search

Automattic / simplenote-ios

Simplenote for iOS
https://simplenote.com
GNU General Public License v2.0
2.05k stars 284 forks source link

Fixed an issue can activate the faceid switch without a passcode #1595

Closed charliescheer closed 6 months ago

charliescheer commented 6 months ago

Fix

Currently there is an issue where you can activate the FaceID/Biometry lock switch for Simplenote without entering a passcode. We do not permit this, and the biometry doesn't actually activate, but default setting changes and the switch appears like it is active. This PR fixes that.

Steps to repro on trunk:

  1. with PIN code and biometry disabled go to the settings view
  2. enable the faceID switch without putting in a passcode
  3. Swipe up and close out of the app without dealing with the modal.
  4. Relaunch the app and go back to settings, you will see that the biometry switch is active, but it shouldn't be.

Test

  1. with PIN code and biometry disabled go to the settings view
  2. enable the faceID switch without putting in a passcode
  3. Swipe up and close out of the app without dealing with the modal.
  4. Relaunch the app and go back to settings, you will see that the biometry switch is not active

Confirm you can set a passcode and activate biometry.

Review

(Required) Add instructions for reviewers. For example:

Only one developer is required to review these changes, but anyone can perform the review.

Release

(Required) Add a concise statement to RELEASE-NOTES.txt if the changes should be included in release notes. Include details about updating the notes in this section. For example:

RELEASE-NOTES.txt was updated in b2f88d with:

Fixed an issue can activate the faceid switch without a passcode

dangermattic commented 6 months ago
1 Error
:no_entry_sign: PR requires at least one label.

Generated by :no_entry_sign: Danger