Magic Links: Switch to Code Authentication - Githubissues

Automattic / simplenote-ios

Simplenote for iOS

https://simplenote.com

GNU General Public License v2.0

2.04k stars 284 forks source link

Magic Links: Switch to Code Authentication #1611

Closed jleandroperez closed 2 weeks ago

jleandroperez commented 3 weeks ago

Details:

[x] Wire the new code-based endpoints
[x] Update the Magic Link Handler so that it manages the new parameters
[x] Implement a new flow that would allow users to type the code
[x] Code UI requires a header
[x] Verify the Invalid Token UI is still triggered
[x] Verify the Magic Link Flow is still supported
[x] Improve Error Handling: 429 / Request Code directly in the Code UI?
[x] Fix Unit Tests
[x] Return nil when fields are empty

Mockups

dangermattic commented 3 weeks ago

Thanks for reporting! 👍