Automattic / simplenote-ios

Simplenote for iOS
https://simplenote.com
GNU General Public License v2.0
2.05k stars 284 forks source link

Updates Translations #1638

Closed jleandroperez closed 3 months ago

jleandroperez commented 3 months ago

Fix

In this PR we're updating the Localizations. For the record:

  1. I've edited fastlane/Fastfile and commented out L205-212 and L179
  2. Executed bundle exec fastlane finalize_release

@mokagio Would it be possible to confirm if doing this was required, or it's just part of the regular release process? I think it wasn't really needed?

Thanks in advance!!

Test

Release

These changes do not require release notes.

dangermattic commented 3 months ago
1 Warning
:warning: This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by :no_entry_sign: Danger

wpmobilebot commented 3 months ago
Simplenote Prototype Build📲 You can test the changes from this Pull Request in Simplenote Prototype Build by scanning the QR code below to install the corresponding build.
App NameSimplenote Prototype Build Simplenote Prototype Build
Build Numberpr1638-78800f0-01914cf5-8be5-47ca-94fc-9a48fd90c7ff
Version4.52
Bundle IDcom.codality.NotationalFlow.Alpha
Commit78800f013e1a0ed400d4405cc50363be065ef8c5
App Center BuildSimplenote - Installable Builds #330
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
jleandroperez commented 3 months ago

TY!

mokagio commented 3 months ago

@jleandroperez the diff looks good—assuming the desired result was to get the latest changes from GlotPress into the app.

I was going to ask whether you tried running new_beta, but upon looking at the source I noticed a mistake, so even if you had tried, it would have failed.

Leaving aside that temporary issue, generally, we shouldn't need to manually download strings, and are better off triggering new betas to update them.

jleandroperez commented 3 months ago

Thank you @mokagio !! Next time we won't be manually updating strings, then.

I've used a patched version of finalize_release.

Hope you're doing great sir!!