Closed jleandroperez closed 3 months ago
1 Warning | |
---|---|
:warning: | This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews. |
Generated by :no_entry_sign: Danger
App Name | Simplenote Prototype Build | |
Build Number | pr1638-78800f0-01914cf5-8be5-47ca-94fc-9a48fd90c7ff | |
Version | 4.52 | |
Bundle ID | com.codality.NotationalFlow.Alpha | |
Commit | 78800f013e1a0ed400d4405cc50363be065ef8c5 | |
App Center Build | Simplenote - Installable Builds #330 |
TY!
@jleandroperez the diff looks good—assuming the desired result was to get the latest changes from GlotPress into the app.
I was going to ask whether you tried running new_beta
, but upon looking at the source I noticed a mistake, so even if you had tried, it would have failed.
Leaving aside that temporary issue, generally, we shouldn't need to manually download strings, and are better off triggering new betas to update them.
Thank you @mokagio !! Next time we won't be manually updating strings, then.
I've used a patched version of finalize_release
.
Hope you're doing great sir!!
Fix
In this PR we're updating the Localizations. For the record:
fastlane/Fastfile
and commented out L205-212 and L179bundle exec fastlane finalize_release
@mokagio Would it be possible to confirm if doing this was required, or it's just part of the regular release process? I think it wasn't really needed?
Thanks in advance!!
Test
Release