Fix broken localization automation in release branch

[mokagio]

I was checking the diff for #1638 after @roundhill pointed out that it looked like the Simplenote iOS build did not pick up new localizations.

I discovered that was indeed the fact and it was due to an old tooling migration that never had the chance to be properly tested IRL due to Simplenote being in maintenance mode.

I was surprised that I didn't get a failure, however, when working on #1635 recently. But then I realized that the build and upload step does not include updating the codebase with localization etc. That's the job of new_beta and finalize_release. I didn't run either of those lanes at the time because I wasn't working at that level.

I decided not to commit the metadata changes that would result from running the new automation and leave that as something that will happen during a new beta or release finalization, as it should normally be.

Fix

The fix really is more of a completion of the tooling upgrade, actually implementing the "modern" localization workflows.

Test

I tested these locally and you can do the same by running:

• bundle exec fastlane download_localized_strings_from_glotpress ... Nothing to commit (unless new localizations changed on GlotPress)
• bundle exec fastlane download_localized_metadata_from_glotpress ... Same (or similar depending on GlotPress' state) to https://github.com/Automattic/simplenote-ios/compare/mokagio/fix-download-localizations...mokagio/test-new-localization-automation

Review

Only one developer required to review these changes, but anyone can perform the review.

These changes do not require release notes.

[dangermattic]

	1 Message
:book:	This PR has the Releases label: some checks will be skipped.

Generated by :no_entry_sign: Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in Simplenote Prototype Build by scanning the QR code below to install the corresponding build.

	App Name	Simplenote Prototype Build
	Build Number	pr1639-6f6fd4a-01915581-8c49-49b5-9b80-7a87bad6b974
	Version	4.52
	Bundle ID	com.codality.NotationalFlow.Alpha
	Commit	6f6fd4abf1115c968c69906b7653e8884366ed2d
	App Center Build	Simplenote - Installable Builds #332

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[mokagio]

I'm going to admin-merge this to move on with shipping a new beta.

@AliSoftware I'll try to followup with the release_notes.txt source of truth update within the week...