Automattic / simplenote-ios

Simplenote for iOS
https://simplenote.com
GNU General Public License v2.0
2.05k stars 285 forks source link

Convert the bool `beta` flag to string for Buildkite #1669

Closed mokagio closed 3 weeks ago

mokagio commented 3 weeks ago

This should address the failure seen running the new buildkite_pipeline_upload in CI:

/opt/ci/builds/builder/automattic/simplenote-ios/vendor/bundle/ruby/3.2.0/gems/fastlane-2.225.0/fastlane/lib/fastlane/helper/sh_helper.rb:118:in `block in shell_command_from_args': [!] undefined method `shellescape' for true:TrueClass (NoMethodError)
      command = args.shift.map { |k, v| "#{k}=#{v.shellescape}" }.join("") + " "

https://buildkite.com/automattic/simplenote-ios/builds/1184#0192d797-332d-4bed-990a-0101000f2f56

dangermattic commented 3 weeks ago
1 Warning
:warning: This PR is assigned to the milestone 4.55 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by :no_entry_sign: Danger

mokagio commented 3 weeks ago

Bypassing CI checks because this change does not run in the standard CI pipeline. We'll validate it next by retrying the complete code freeze pipeline.

wpmobilebot commented 3 weeks ago
Simplenote Prototype Build📲 You can test the changes from this Pull Request in Simplenote Prototype Build by scanning the QR code below to install the corresponding build.
App NameSimplenote Prototype Build Simplenote Prototype Build
Build Numberpr1669-5539e0f-0192d79b-e603-445e-8f2a-0e59b2340e4f
Version4.55
Bundle IDcom.codality.NotationalFlow.Alpha
Commit5539e0fd62906ba874328f8471a946e41e23e2ca
App Center BuildSimplenote - Installable Builds #394
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.