Automattic / simplenote-ios

Simplenote for iOS
https://simplenote.com
GNU General Public License v2.0
2.05k stars 285 forks source link

Fix Simplenote iOS metadata automation not detecting en-US #1684

Open mokagio opened 2 weeks ago

mokagio commented 2 weeks ago

During the 4.55 finalization, I got this error in ASC

Image

Turns out the en-US "What's new" metadata had not been uploaded...

That is confirmed by looking at the CI logs

[14:20:02]: Detected languages: ["ar-SA", "de-DE", "default", "es-ES", "fr-FR", "he", "id", "it", "ja", "ko", "nl-NL", "pt-BR", "ru", "sv", "tr", "zh-Hans", "zh-Hant"]

I worked around this manually in the context of 4.55 for time constraints by adding the release notes in ASC myself, but this ought to be fixed before handing over to developers.


Two ideas:

dangermattic commented 2 weeks ago

Thanks for reporting! 👍