After a brief discussion with @aforcier we decided it was best to remove the last trace of synthetics from the PhotoEditor class (which is removed in Kotlin 1.4.20) without half-introducing view binding, leaving things in a better place for a proper refactor using viewbindingto be analyzed in the future.
WordPress Android uses Kotlin 1.4.10 so, once it gets bumped there the Stories library will likely get a bump in Kotlin version here (for which the kotlin-parcelize plugin will have to be introduced as well when that time comes)
This PR then only removes synthetics and falls back to using good old findViewById.
To test:
open the demo app
create a slide or two
add some views
verify you can drag them around, resize, rotate, edit, etc.
After a brief discussion with @aforcier we decided it was best to remove the last trace of synthetics from the PhotoEditor class (which is removed in Kotlin 1.4.20) without half-introducing view binding, leaving things in a better place for a proper refactor using
viewbindingto be analyzed in the future.WordPress Android uses Kotlin 1.4.10 so, once it gets bumped there the Stories library will likely get a bump in Kotlin version here (for which the
kotlin-parcelizeplugin will have to be introduced as well when that time comes)This PR then only removes synthetics and falls back to using good old
findViewById.To test: