search

Automattic / stories-android

Loop concept app - WP Stories library
GNU General Public License v2.0
20 stars 6 forks source link

Add view binding for IntroActivity in demo app #703

Closed aforcier closed 3 years ago

aforcier commented 3 years ago

Fixes an issue where a fresh install of the Loop app would crash on launch in the view binding branch. It looks like the view binding setup for IntroActivity was missing, probably nobody noticed because the activity isn't shown once you've already granted the permissions the app needs.

To test

  1. Uninstall the loop app if you have it installed
  2. Build this branch (there should be an installable build comment made automatically on this PR)
  3. Confirm that you see an intro screen, you're able to grant permissions, and are taken to the next screen (which says "Still working on this! Tap the + to continue.")
peril-automattic[bot] commented 3 years ago

You can test the changes on this Pull Request by downloading the APK here.