Automattic / stories-android

Loop concept app - WP Stories library
GNU General Public License v2.0
17 stars 6 forks source link

Re-enable fetchstyle plugin and request it from s3 repository #705

Closed oguzkocer closed 3 years ago

oguzkocer commented 3 years ago

Since the source code for fetchstyle plugin is heavily outdated, I couldn't fully update it in the time I allotted for it. I actually successfully published the plugin to S3, but there was something wrong with the groovy dependency, so it didn't work when I tried to consume it. So, for now, I've manually ported the fetchstyle plugin from jcenter to our s3 repository.

Edit: I realized there was one last thing I forgot to revert from https://github.com/Automattic/stories-android/pull/674 and that's to re-enable the checkstyle task in CI. I've done this in 359ba35f1973912d414996a2dd99c0a60304243c. This task should have never been commented out because it had nothing to do with the fetchstyle plugin, but I didn't recognize this during that day's craziness.

To test:

Screen Shot 2021-06-13 at 4 44 51 PM

peril-automattic[bot] commented 3 years ago

You can test the changes on this Pull Request by downloading the APK here.