Automattic / stories-android

Loop concept app - WP Stories library
GNU General Public License v2.0
17 stars 6 forks source link

Address WPAndroid ClickableViewAccessibility lint errors #706

Closed aforcier closed 3 years ago

aforcier commented 3 years ago

It looks like the view binding update (#688) created a few cases of the ClickableViewAccessibility lint check. Nothing changed feature-wise, I'm guessing the check just parses view binding based code differently and recognized something where it didn't before. I noticed this in https://github.com/wordpress-mobile/WordPress-Android/pull/14928, which is trying to pull the view binding changes from this library into WPAndroid.

ClickableViewAccessibility is a warning by default, but WPAndroid has promoted this to an error.

We have an open issue (#499) to eventually try to address some ClickableViewAccessiblity suppressions we already have, which I believe were imported with the original photoeditor library. (It may in fact be a true false positive in some cases due to how we're handling clicks.)

For now, to unblock that PR, I'm suppressing the lint check in the areas where it's now being flagged. I've also imported the lint.xml file from WPAndroid to make this less likely to happen in the future (I removed a few obvious WPAndroid-specific things). Ideally this will be part of better tooling in the future allowing us to share the lint.xml between projects with local custom rules.

To test

peril-automattic[bot] commented 3 years ago

You can test the changes on this Pull Request by downloading the APK here.

malinajirka commented 3 years ago

Works as expected, thanks! 🙇