Update minSdk to 24 - Githubissues

Automattic / stories-android

Loop concept app - WP Stories library

GNU General Public License v2.0

20 stars 6 forks source link

Update minSdk to 24 #711

Closed oguzkocer closed 3 years ago

oguzkocer commented 3 years ago

After an internal discussion, we decided to upgrade minSdk to for WordPress-Android to 24 as we have less than 5% of our users on the earlier versions of Android.

Besides upgrading the minSdk, it removes obsolete checks for the earlier versions of sdk. I suggest turning on the hide whitespaces option to review these changes.

To test:

I think we should smoke test the app and then smoke test the WPAndroid PR? I am not sure if this change can have any effect in the app to be honest.

peril-automattic[bot] commented 3 years ago

You can test the changes on this Pull Request by downloading the APK here.

oguzkocer commented 3 years ago

@cameronvoell @aforcier I've requested a review from you for this PR and then reverted that because it looks like there are still a couple things to fix. I'll request a review again once everything is in order. I am sorry for the premature ping!