Fixes attaching images taken with camera on Story posts

Automattic / stories-android

Loop concept app - WP Stories library

GNU General Public License v2.0

20 stars 6 forks source link

Fixes attaching images taken with camera on Story posts #718

Closed ravishanker closed 2 years ago

ravishanker commented 2 years ago

This issue is due to using deprecated api and recent upgrade to android 11 (API 30) has probably exposed the issue.

https://developer.android.com/reference/android/content/Context.html#getExternalFilesDir(java.lang.String)

Fixed by updating getExternalStorageDirectory to getExternalFilesDir

To test:

This needs to be tested from WordPress app using the related PR and steps there

peril-automattic[bot] commented 2 years ago

You can test the changes on this Pull Request by downloading the APK here.

ravishanker commented 2 years ago

👋 @AliSoftware Should the version be updated to 1.2.1 or 1.3.0 when this PR is merged. Not sure what the convention is here. Thank you

AliSoftware commented 2 years ago

👋 @AliSoftware Should the version be updated to 1.2.1 or 1.3.0 when this PR is merged. Not sure what the convention is here. Thank you

That's a good question. I think using 1.2.1 would make more sense here as this is to fix something already in the release/19.0 branch in the client app.

AliSoftware commented 2 years ago

I'm gonna to take point and merge this then create a new GH Release and version 1.2.1, then update https://github.com/wordpress-mobile/WordPress-Android/pull/15832 accordingly before merging it too.

AliSoftware commented 2 years ago

This has now been shipped in stories:1.2.1 and included in the new WPAndroid and JPAndroid 19.0-rc-4 betas 🎉