Automattic / stories-android

Loop concept app - WP Stories library
GNU General Public License v2.0
17 stars 6 forks source link

CI - Missing Lint Artifacts (And CheckStyle) #720

Open ParaskP7 opened 2 years ago

ParaskP7 commented 2 years ago

TL;DR

As part of Gradle 7.4 & AGP to 7.1.1 upgrade, I noticed that only the stories module related Lint set of artifacts are being uploaded during a CI build (see ~/lint/lint-results-release.html/txt/xml). However, there are three more Lint related artifacts that need to be uploaded as well, for the mp4compose, photoeditor and app modules.

PS: The same actually applies to CheckStyle related artifacts.

Details

This is most probably due to the way the Save lint results and Uploading artifacts works, which copies any Lint related artifacts that match the .*/build/reports/.* regex, thus overriding previous set of artifacts. This script probably expects that a repo would only contain one set of Lint related artifacts. But, for this repo we are actually interested in four sets of Lint related artifacts, for the below modules:

Thus, and since the stories probably runs last, this set of Lint artifacts overrides any preceding sets of Lint artifacts, leaving only those to be then uploaded.

PS: The exact same applies to the CheckStyle artifacts.