Android 12: Security and privacy - Pending intents mutability (Stories) - Githubissues

Automattic / stories-android

Loop concept app - WP Stories library

GNU General Public License v2.0

17 stars 6 forks source link

Android 12: Security and privacy - Pending intents mutability (Stories) #721

Closed ashiagr closed 2 years ago

ashiagr commented 2 years ago

Sets PendingIntent mutability as part of Android 12 migration changes.

Corresponding WPAndroid PR: https://github.com/wordpress-mobile/WordPress-Android/pull/16082

How I tested?

Checked out referenced WPAndroid PR branch.
Enabled stories lib from WPAndroid's local-builds.gradle.
With stories lib branch for this PR checked out, commented if condition inside FrameSaveService.prepareStorySaveResult so that handleErrors gets executed:

//        if (!noErrors) {
            // let's handle these errors
            handleErrors(storySaveProcessor.storySaveResult)
//        }

Installed the app and published a story.
Noticed that the error notification shown and FrameSaveNotifier.updateNotificationErrorForStoryFramesSave is executed properly with the new pending intent mutability.

peril-automattic[bot] commented 2 years ago

You can test the changes on this Pull Request by downloading the APK here.