Automattic / stories-android

Loop concept app - WP Stories library
GNU General Public License v2.0
20 stars 6 forks source link

[Build] Remove Fetch Style Plugin #725

Closed ParaskP7 closed 1 year ago

ParaskP7 commented 1 year ago

This PR removes the fetchstyle plugin from the project.

This style-config-android plugin is mostly unused and very outdated.

To the Apps Infra's knowledge and checking GE stats no-one is using the ./gradlew downloadConfigs task to fetch/update the style config files. For years now, almost all Android engineers depend on the default AS style and such like .idea configuration.

PS: For more info please refer to this internal discussion here: C02QANACA/p1667910471807479


To test:

peril-automattic[bot] commented 1 year ago

You can test the changes on this Pull Request by downloading the APK here.

ParaskP7 commented 1 year ago

👋 @oguzkocer !

For some reason me enabling auto-merge for this PR didn't respect the fact that it first needs an approval. Thus, it merge this PR automatically after all the CI checks successfully completed... 😞

Maybe we should consider adding that restriction, wdyt? 🤔

ParaskP7 commented 1 year ago

@ParaskP7 I've enabled Require a pull request before merging > Require approvals. :shipit:

Awesome, thank you so much @oguzkocer ! 🙇