search

Automattic / stories-android

Loop concept app - WP Stories library
GNU General Public License v2.0
17 stars 6 forks source link

Android 13 migration update compile and target sdk versions to 33 #728

Closed ravishanker closed 1 year ago

ravishanker commented 1 year ago

Updates compileSdkVersion and targetSdkVersion from 31 to 33 (Android 13)

Internal project thread: pbArwn-5IN-p2

Fixes: #18096

To test

ravishanker commented 1 year ago

@ParaskP7 - Looks like stories-android still has CircleCI checks!

ParaskP7 commented 1 year ago

👋 @ravishanker !

@ParaskP7 - Looks like stories-android still has CircleCI checks!

You're right, it looks that the CircleCI to Buildkite migration hasn't been completed for this repo, just like it happened for the rest of them, and to be honest, I am not sure why... 🤔 Cc @oguzkocer

oguzkocer commented 1 year ago

@jkmassel was working on these migrations, but we have a lot of repos, so it's most likely an oversight. If this is a blocker, I can try and handle this migration this week.

ravishanker commented 1 year ago

@jkmassel was working on these migrations, but we have a lot of repos, so it's most likely an oversight. If this is a blocker, I can try and handle this migration this week.

@oguzkocer Yes, please. Thank you

oguzkocer commented 1 year ago

@oguzkocer Yes, please. Thank you

I've moved the lint & unit test tasks to Buildkite in #729. I'm waiting some feedback from the App Infrastructure Team about the installable build, but worst case scenario, we can merge #729 tomorrow and open a separate PR for the installable build.

@ravishanker If you can let me know the urgency of this PR, I can take the appropriate action. Thank you!

irfano commented 1 year ago

@oguzkocer Yes, please. Thank you

I've moved the lint & unit test tasks to Buildkite in #729. I'm waiting some feedback from the App Infrastructure Team about the installable build, but worst case scenario, we can merge #729 tomorrow and open a separate PR for the installable build.

@ravishanker If you can let me know the urgency of this PR, I can take the appropriate action. Thank you!

Thank you for handling this, @oguzkocer! This is not too urgent and does not need to be merged this week. It can be merged in our next sprint.

oguzkocer commented 1 year ago

Thanks @irfano! https://github.com/Automattic/stories-android/pull/729 is now ready for review, so it should be merged early next week 🤞

oguzkocer commented 1 year ago

@ravishanker @irfano https://github.com/Automattic/stories-android/pull/729 is merged. You can merge trunk into this branch which should trigger Buildkite to run the jobs instead of CircleCI. Please let me know if you have any issues!

ravishanker commented 1 year ago

I tested the Loop demo app but it isn't going to the next screen after requesting permission. I think the permission code needs to be updated.

It has READ_EXTERNAL_STORAGE and WRITE_EXTERNAL_STORAGE . Better handle that separately as part of media permissions task