Automattic / stories-android

Loop concept app - WP Stories library
GNU General Public License v2.0
17 stars 6 forks source link

[Build] Update Kotlin to 1.6.10 #734

Closed ParaskP7 closed 1 year ago

ParaskP7 commented 1 year ago

This PR is a prerequisite for the Gradle 8.1.1 & AGP 8.0.2 Upgrade for WPAndroid, WCAndroid & Related Libs project.

Platform Request: pdnsEh-13V-p2 Project Thread: paaHJt-57Z-p2


This PR upgrades Kotlin to 1.6.10.

FYI: This is primarily done to unblock development with JDK17.

PS: It also includes the following: Remove unnecessary kotlin stdlib dependency from all modules


Lint Fix List:

  1. Fix lint build warning on file not existing
  2. Fix lint build failure on could not find org wordpress lint
  3. Fix lint build failure on androidx test espresso manifest merger
  4. Add lint check to buildkite linters group

Test Restructure List:

  1. Remove all ui test related configuration from project
  2. Remove unnecessary unit test related configuration from project
  3. Update junit to 4.13.2
  4. Remove unnecessary kotlin test junit dependency

Dependency Versions Refactor List:

  1. Extract all sdk version to a separate ext block
  2. Rename lifecycle to androidx lifecycle version
  3. Rename coroutines to kotlinx coroutines version
  4. Rename constraint layout to androidx constraint layout version
  5. Rename appcompat to androidx appcompat version
  6. Rename core to androidx core version
  7. Rename navigation to androidx navigation version
  8. Rename serialization to kotlinx serialization version
  9. Extract glide version to root build gradle
  10. Extract glide transformations version to root build gradle
  11. Extract wordpress lint version to root build gradle
  12. Extract androidx camera version to root build gradle
  13. Extract google material version to root build gradle
  14. Extract chrisbanes photoview version to root build gradle
  15. Extract androidx emoji version to root build gradle
  16. Extract androidx recyclerview version to root build gradle
  17. Extract event bus version to root build gradle
  18. Extract junit version to root build gradle
  19. Extract androidx preference version to root build gradle
  20. Remove duplicate androidx preference ktx dep from app module
  21. Extract sentry android version to root build gradle
  22. Extract sentry version to settings build gradle
  23. Extract automattic publish to s3 version to settings build gradle
  24. Extract slf4j version to root build gradle
  25. Extract debug versions to root build gradle
  26. Add versions groups to root build gradle

To test

  1. Verify that all the CI checks are successful (especially the newly added Lint check).
  2. Smoke test the app.
  3. Test for build time increases (Local & CI).
ParaskP7 commented 1 year ago

Thank you for reviewing and testing this @oguzkocer , you rock! 🙇 ❤️ 🚀