Automattic / stories-android

Loop concept app - WP Stories library
GNU General Public License v2.0
17 stars 6 forks source link

[Compile Warnings As Errors] Resolve Warnings & Enable All Warnings as Errors #735

Closed ParaskP7 closed 1 year ago

ParaskP7 commented 1 year ago

This PR resolves/suppresses all warnings for all modules and then enables all warnings as errors as the default for this project (a976caf9c721c7d54c8f4c9e58ca4d92c5af48de).

PS: This is just a follow-up PR of the previous more important #734 PR to restrict further Kotlin related warnings to creep into this repo and with it to also enable future Kotlin updates, for example see below warning that would have made the Kotlin 1.7 update a bit more in the future:

Non exhaustive 'when' statements on enum will be prohibited in 1.7, add 'XYZ' branches or 'else' branch instead


Warnings Resolution List:

Warnings Suppression List:


To test

  1. There is nothing much to test here (if not all, most of the deprecated warnings were suppressed).
  2. Verifying that all the CI checks are successful should be enough.
  3. However, if you want to be thorough about reviewing this change, you could quickly smoke test the example app and see if it is working as expected.
ParaskP7 commented 1 year ago

Thank you for reviewing and testing this @oguzkocer , you rock! šŸ™‡ ā¤ļø šŸš€