search

Automattic / stories-android

Loop concept app - WP Stories library
GNU General Public License v2.0
17 stars 6 forks source link

Add a guard to avoid calling Glide load when activity is destroyed #739

Closed mkevins closed 10 months ago

mkevins commented 11 months ago

Related PR

https://github.com/wordpress-mobile/WordPress-Android/pull/18850

Description

This PR adds a guard to avoid calling Glide's load when the activity is destroyed, which otherwise leads to a crash on a failed assertion. More details can be found here: https://github.com/wordpress-mobile/WordPress-Android/issues/18809.

To test:

Test via the steps in the description of the related PR.

mkevins commented 10 months ago

Thanks for reviewing this Irfan! This is ready for another pass.

mkevins commented 10 months ago

Thanks for reviewing and testing Irfan!