search

Automattic / stories-android

Loop concept app - WP Stories library
GNU General Public License v2.0
17 stars 6 forks source link

[Fix] Update targetSdk to 34 and fixed a few issues along the way. #745

Closed notandyvee closed 5 months ago

notandyvee commented 5 months ago

Issue: https://github.com/Automattic/stories-android/issues/744 Parent: https://github.com/orgs/wordpress-mobile/projects/223

This PR updates the targetSdk version to 34. During testing, two issues were found:

  1. Services now require a foregroundServiceType.
  2. Sentry needed to be updated. Found an issue on Sentry's repo and the corresponding fix. It was released in 6.32.0. I realize this increases risk, so I only updated Sentry to the lowest possible version that avoided the crash.

Something to note. I used datasync as the foreground service type. This makes sense as we are processing the image and the camera does not need to be open for this. But feel free to make sure I chose the right foreground service type as a second pair of eyes.

Note:

I tested this with the sample app and Wordpress Android. Worked fine on both.