Automattic / studio

Studio by WordPress.com, a free desktop app that helps developers streamline their local WordPress development workflow.
https://developer.wordpress.com/studio/
GNU General Public License v2.0
138 stars 12 forks source link

Use PHP constants from `wp-now` #231

Closed fluiddot closed 2 weeks ago

fluiddot commented 2 weeks ago

Related to https://github.com/Automattic/studio/pull/225.

Proposed Changes

Screenshot 2024-06-11 at 15 34 02

Testing Instructions

  1. Create a new site.
  2. New site should launch with a default version of PHP 8.0.
  3. Navigate to the Studio settings for the site.
  4. Edit the PHP version to a different PHP version.
  5. Observe that the PHP versions listed are the same as the ones offered in https://playground.wordpress.net/.
  6. Verify the server restarts and the site is running the new PHP version.

Pre-merge Checklist

fluiddot commented 2 weeks ago

Thanks, @fluiddot !

I don't think that our default PHP version should be closely coupled to wp-now, but I'll change that in my other PR.

Good point. Yep, I agree there's no need to to use the same value from wp-now.