search

Automattic / studio

Studio by WordPress.com, a free desktop app that helps developers streamline their local WordPress development workflow.
https://developer.wordpress.com/studio/
GNU General Public License v2.0
138 stars 12 forks source link

Remove `getPhpVersion` hook and IPC handler #239

Closed fluiddot closed 1 week ago

fluiddot commented 2 weeks ago

Related to https://github.com/Automattic/studio/pull/225#discussion_r1636268088.

Proposed Changes

Testing Instructions

New Site

  1. Create a new site.
  2. New site should launch with a default version of PHP 8.0.
  3. Open WP admin and navigate to wp-admin/site-health.php?tab=debug.
  4. Open the Server section.
  5. Observe that the PHP version is 8.0.

Old Sites

  1. Install a version of the Studio app before these changes are applied.
  2. Create a new site.
  3. Build/install a version with the changes of this PR.
  4. Select the previously created site.
  5. Go to the Settings tab.
  6. Observe that its PHP version is 8.0.

Change PHP version

  1. Create a new site.
  2. New site should launch with a default version of PHP 8.0.
  3. Go to the Settings tab.
  4. Edit the PHP version of the site (e.g. set version 8.3).
  5. Observe that the site is restarted.
  6. Open WP admin and navigate to wp-admin/site-health.php?tab=debug.
  7. Open the Server section.
  8. Observe that the PHP version is the one previously set (e.g. 8.3).

Pre-merge Checklist