Closed dcalhoun closed 1 week ago
👋🏻 @matt-west. The changes I propose do not include the reduced button padding captured in the design proposal as I was uncertain if we intended to apply that to the "Add site" button as well.
My thought is that the current padding used for all existing buttons looks fine for the inline code buttons (see images in the PR description). If you disagree, we could introduce additional one-off button style modifications for the padding of the inline code buttons. WDYT?
Thanks for implementing this change @dcalhoun.
I think the code buttons need the reduced padding, they're a bit too dominating at the moment. We should keep the existing padding for the Add site
button though. Applying one-off modifications to the code buttons makes sense to me. 👍
Relates to https://github.com/Automattic/studio/pull/214#discussion_r1635129557.
Proposed Changes
Introduce a new
outlined
button variant.Overloading the in-use
tertiary
button variant styles resulted in unexpected and inconsistent styles in the UI --- e.g., the "Add site" dialog. Introducing a newoutlined
variant achieves the original goal of a new button style that is now used in both the sidebar and AI assistant code blocks.Testing Instructions
Expected outline button styles display
[^1]: The "Run" button is currently commented in the source code and thus hidden.
Expected tertiary button styles display
Pre-merge Checklist