Automattic / super-cool-ad-inserter-plugin

Insert ads, newsletter signup widgets, and calls to action in the middle of your posts!
https://wordpress.org/plugins/super-cool-ad-inserter/#description
32 stars 4 forks source link

test: Upgrade to php 8 #123

Closed leogermani closed 2 years ago

leogermani commented 2 years ago

This upgrades the tests so they can run both on php 7.4 and 8.

To test it, load the repo in a php 8 environment and run composer install. the run ./vendor/bin/phpunit

Do the same thing on a php 7.4 environment, but run composer update instead of install. (Discard the changes to composer.lock afterwards)

The CI failing here is expected, as we need to update them to either use php8 or run composer update

matticbot commented 1 year ago

:tada: This PR is included in version 0.6.3-alpha.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

matticbot commented 1 year ago

:tada: This PR is included in version 0.6.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: