Prevent shortcode inserter from wrapping to the start of a post - Githubissues

Automattic / super-cool-ad-inserter-plugin

Insert ads, newsletter signup widgets, and calls to action in the middle of your posts!

https://wordpress.org/plugins/super-cool-ad-inserter/#description

32 stars 4 forks source link

Prevent shortcode inserter from wrapping to the start of a post #20

Closed benlk closed 8 years ago

benlk commented 8 years ago

Changes

Checks that the paragraph position being inserted in is set in the array of paragraph positions
Checks that the paragraph position being inserted in is greater than the last paragraph position that was set in
Defines the variable $i used in the shortcode inserter while loop to take care of an undefined variable notice (#17)
Why

$paragraph_positions[$i] wasn't set when $i was equal to count($paragraph_positions) and ($i + 1 ) % $scaip_period == 0.

This is because $paragraph_positions is zero-indexed and count( starts counting from 1, so it was an off-by-one error.