Version 0.2

[benlk]

Changes

• Version 0.2
• Tested up to WordPress 5.0-beta2
• Updates to latest version of https://github.com/INN/docs/blob/master/projects/wordpress-plugins/release.sh.md
• Fixes Internet Explorer compatibility in the editor
• Fixes enqueue dependencies on block.js so this works in Gutenberg in WP 5.0.
• Fixes, syntax, small: numerous

[benlk]

Blocked by https://github.com/INN/super-cool-ad-inserter-plugin/blob/43d9114d6b39a83da590bc5e0ba53b6b8e39d054/blocks/scaip-sidebar/block.js#L139-L147

[benlk]

I think we're safe using something from 2000. I hope.

[benlk]

Downloading a https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/ IE11 VM to check, because I don't like that "I hope".

[benlk]

Couldn't figure out how to get valet to talk directly to the virtualbox VM; used valet share and renamed the site URL to use an ngrok.io URL to access the site in the VM. IE11's 404 page is pretty indistinguishable from IE11's "Could not connect" page.

IE 11 is of course complaining about syntax errors that other browsers did not. Will continue tomorrow.

[benlk]

For Valet compatibility with the modern.ie VM, I had to add a line to the VM's hosts file to point IE to the correct IP address for the testing site, because Valet determines which site to display based on the requested domain name. (To make this easier, I propose a couple changes to Valet: https://github.com/laravel/valet/issues/661)

Thanks to jslint.com, a number of changes have been made to reduce syntax errors in the JS that IE11 was tripping over, but not modern Chrome, Firefox, or Safari.

WordPress 5.0 testing was done with:

wp core download 5.0-beta1 --force
wp core update

I'm now on 5.0-beta2-43845.

[benlk]

For Valet compatibility with the modern.ie VM, I had to add a line to the VM's hosts file to point IE to the correct IP address for the testing site, because Valet determines which site to display based on the requested domain name. (To make this easier, I propose a couple changes to Valet: https://github.com/laravel/valet/issues/661)

Thanks to jslint.com, a number of changes have been made to reduce syntax errors in the JS that IE11 was tripping over, but not modern Chrome, Firefox, or Safari.

[benlk]

Testing without Gutenberg revealed https://github.com/INN/super-cool-ad-inserter-plugin/issues/42, which ... is not a problem we can fix.

[benlk]

And now it works without Gutenberg.

[benlk]

Testing before release:

Plugin settings:

• [x] Does the settings page work?

Post meta boxes

• [x] The metabox checkbox disabling automatic ad insertion should work.

Shortcode tests

• [x] The [ad no] shortcode should suppress automatic ad insertion.
• [x] A [ad] shortcode should not display.
• [x] An [ad number=1] or [ad number=2] shortcode should display the relevant sidebar.
• [x] An [ad number=2 align=left] shortcode should have the class alignleft.

Gutenberg tests

• [x] the block, when inserted, inserts ad position 1
• [x] the existence of the block in the post prevents the automatic inserter from running
• [x] the block's ad position selector, custom classes, and alignment options are respected.
• [x] on a site with Gutenberg not installed, the plugin functions
• [x] on a 4.9 site with Gutenberg installed, the plugin functions
• [x] on a 5.0 site, the plugin functions