search

Automattic / super-cool-ad-inserter-plugin

Insert ads, newsletter signup widgets, and calls to action in the middle of your posts!
https://wordpress.org/plugins/super-cool-ad-inserter/#description
32 stars 4 forks source link

Are any changes necessary after Gutenberg added support for the 'disabled' attribute in SelectControl options? #48

Closed benlk closed 4 years ago

benlk commented 5 years ago

https://github.com/WordPress/gutenberg/issues/11270 is an issue we opened because Gutenberg didn't support passing the disabled HTML attribute to the <option> of a <select>.

That's been fixed in Gutenberg in https://github.com/WordPress/gutenberg/commit/7d2006619aed575a3f9b19f34e84fb4cd70248a0, in https://github.com/WordPress/gutenberg/pull/15976, sometime around Gutenberg 6.2.0

adekbadek commented 4 years ago

I can see the disabled option here is working as expected.