search

Automattic / super-cool-ad-inserter-plugin

Insert ads, newsletter signup widgets, and calls to action in the middle of your posts!
https://wordpress.org/plugins/super-cool-ad-inserter/#description
32 stars 4 forks source link

Update block editor style to look like a `Placeholder` #58

Closed thomasguillot closed 3 years ago

thomasguillot commented 4 years ago

At the moment, the editor stylesheet doesn't load. This PR fixes it. AND style the block like a Gutenberg Placeholder.

How to test

  1. On a page/post/CPT, add the block
  2. Notice how unstyled it is (and check the sidebar -- note: why do we need the setting there as well??)
  3. Switch to this branch
  4. 🧙‍♂️

Closes #44

benlk commented 4 years ago

Is there any reason to not replace it with a Placeholder?

thomasguillot commented 4 years ago

Is there any reason to not replace it with a Placeholder?

Good point 😅 Done in https://github.com/Automattic/super-cool-ad-inserter-plugin/pull/58/commits/619e3ff94991d7dc7443c69cae2003dc74b4a20d