Automattic / super-cool-ad-inserter-plugin

Insert ads, newsletter signup widgets, and calls to action in the middle of your posts!
https://wordpress.org/plugins/super-cool-ad-inserter/#description
32 stars 4 forks source link

[WP 5.8] Error message in widgets block editor #61

Closed dkoo closed 3 years ago

dkoo commented 3 years ago

In the new blocks-based widget editor, having the Super Cool Ad Inserter plugin active will result in an error message being shown at the top of the editor:

Screen Shot 2021-07-09 at 3 35 49 PM
daria2303 commented 3 years ago

Another one: 4200471-zd-woothemes

Workaround: Classic Widgets plugin

synora commented 3 years ago

The ticket above has come off-hold and updates about this issue are being requested. p1630595750064200-slack-C01UW7SB411

@adekbadek 👋 Would you be able to assist with this?

adekbadek commented 3 years ago

I can't reproduce that neither on master nor on an earlier version.

In the new blocks-based widget editor, having the Super Cool Ad Inserter plugin active will result in an error message being shown at the top of the editor:

@dkoo - the error message mentions more details in the developer tools - could you please share those?

dcoleonline commented 3 years ago

I'm just adding a note to make sure we get back to the user in 4200471-zen once this is resolved. I'll close the ticket there as it's been on hold for some time.

dkoo commented 3 years ago

@adekbadek @dcoleonline I saw this error during the WP 5.8 beta testing. I can no longer replicate it on my test site nor a new ephemeral test site.

However, I took a look into ticket #4200471 and looked at the site in question, and it doesn't look like this site is using the Super Cool Ad Inserter plugin at all, so I don't believe this ticket is related to this particular GitHub issue.

dkoo commented 3 years ago

Since I can't replicate with SCAIP active on my local test site or a new test site, I'm closing this issue as "can't replicate"/"won't fix". Steps to confirm:

  1. On a new test site, disable the widget block editor using a filter, e.g.
// Disables the block editor from managing widgets.
add_filter( 'use_widgets_block_editor', '__return_false' );
  1. Install/activate SCAIP and in the classic widget editor, add some Text widgets to the SCAIP widget areas. Confirm that they render as expected in post content.

  2. Re-enable the widget block editor and view the Widgets page. Confirm that there's no error message and the SCAIP widgets continue to be available in the editor and render in the expected placements on the front-end.