search

Automattic / super-cool-ad-inserter-plugin

Insert ads, newsletter signup widgets, and calls to action in the middle of your posts!
https://wordpress.org/plugins/super-cool-ad-inserter/#description
32 stars 4 forks source link

chore: use newspack-scripts #94

Closed dkoo closed 2 years ago

dkoo commented 2 years ago

Implements newspack-scripts as in https://github.com/Automattic/newspack-plugin/pull/1368 and https://github.com/Automattic/newspack-new-plugin-boilerplate/pull/3.

This repo is a little different from our others since it's an inherited plugin. There's no JS or SCSS to build here.

  1. Run npm start and smoke test the plugin's basic functionality with setting the number of widget areas, inserting widgets into the widget areas, and seeing them render on the front-end.
  2. Run npm run semantic-release and verify that it runs (it should run in dry mode and complete without doing anything because you're not running it on release or alpha).
  3. Verify commitizen works by staging a change and running npm run cm – a prompt for a structured commit message should appear, just line on master
  4. Verify the commit-msg hook does lint the commit message:
    1. reinstall the hook – composer install
    2. stage a change and try to commit with an unstructured commit message (e.g. git commit -m "hehe") and observe it failing.
matticbot commented 2 years ago

:tada: This PR is included in version 0.6.1-alpha.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

matticbot commented 2 years ago

:tada: This PR is included in version 0.6.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: