Open philipjohn opened 7 years ago
philipjohn
commented
7 years ago Basic functionality:
philipjohn
commented
7 years ago Some progress in test-coverage
MattGeri
commented
7 years ago @philipjohn I've completed all the tests except for the PUSH operations.
You've mentioned that for the XML RPC push tests, we should probably use Multisite, however when running tests, a web server is not involved and so it wouldn't be possible to send requests from one site to another.
The only option here is mocking. However the code isn't written using dependency injection so it's quite difficult. What I am currently thinking is that we try intercept the HTTP calls and return the response we expect to get from the XMLRPC service. The same would go for the REST service.
What do you think of the above? Any other suggestions?
MattGeri
commented
7 years ago @philipjohn I went ahead and implemented the interceptor for the XMLRPC push syndications. You can see how it was implemented here:
It's somewhat hackish, but it works and implements a real XMLRPC service, so that tests are pretty solid. It also uses a multisite instance to send the requests from one blog to another and tests the results on the other side.
Let me know your thoughts. PR #136 is ready for final review. It doesn't include REST tests because I will write those as part of issue #116
There are no automated tests for this plugin, which is a shame.
We should ensure good test coverage for checking existing functionality is free of obvious bugs and that new contributions don't introduce regressions.