Automattic / themes

Free WordPress themes made by Automattic for WordPress.org and WordPress.com.
https://themeshaper.com
GNU General Public License v2.0
882 stars 351 forks source link

Canape: Testimonial Archive Page Title not Translated #1928

Closed ash1eygrace closed 4 years ago

ash1eygrace commented 4 years ago

Steps to replicate

  1. Start with a site using the Canape theme, that has at least one testimonial created to generate the testimonial archive page ( e.g https://happyash.co/testimonial <-- My test site)
  2. Change the language of the site (via wp-admin > Settings ) to any language other than English

Result

The title of the Testimonial Archive Page https://happyash.co/testimonial does not translate on the live site. It stays in English. Also, the correct translation of the title shows in the customizer, but the live site is not translating.

Video demonstrating the translation in the customizer vs. the live site: https://d.pr/v/cI1bjr

Expected

I expect the title to be translated into the site's language settings selected in wp-admin.

Tested with other themes and the language of the Testimonial archive page translates as expected. Also, I tested multiple languages in the wp-admin, including Spanish, French, and Italian, none of which translate.

As a temporary fix I gave them the following CSS to hide the page's title and replace it with the correct translation:

/* Hide & add custom title on Testimonial page */
.post-type-archive-jetpack-testimonial .entry-title{
display: none;
}
.post-type-archive-jetpack-testimonial #testimonials::before{
content: "Témoignages";
font-size: 3.6rem;
}
/* end */
nielslange commented 4 years ago

@ash1eygrace The testimonials title can be edited within the Customizer via

{SITE-URL}/wp-admin/customize.php → Testimonials → Testimonials Archive Title

Backend:

![#1928-backend](https://user-images.githubusercontent.com/3323310/79985710-39275180-84d5-11ea-9ada-f4dff497650c.png)
Frontend:

![#1928-frontend](https://user-images.githubusercontent.com/3323310/79985704-375d8e00-84d5-11ea-93eb-9be6fe32b664.png)

I looked up the site as mentioned in #2858965-zd and saw that the title had been corrected within the customizer. When removing the CSS code, the title as provided within the customizer becomes visible then.

Would you mind double-checking this on their site to confirm that it is working as I pointed out above? 😀

ash1eygrace commented 4 years ago

The testimonials title can be edited within the Customizer via

Wow! That was hidden well! :laughing: I'll check after my chat shift and let the customer know! Thanks!

ash1eygrace commented 4 years ago

Checked and it indeed works! Thanks for the TIL! :) I must have missed it since it was in a different language!