Dara: invalid link in WP Admin theme details page

tbradsha commented 4 years ago

Steps to replicate

Install/activate Dara.
Go to **WP Admin → Appearance → Themes.
Hover over the Dara box, and click "Theme Details".

Result

Not that there are two "Background" buttons. The first link is invalid, and triggers a 403 since it goes here:

themes.php?page=https://example.com/wp-admin/customize.php?autofocus%5Bsection%5D=colors_manager_tool

The second one, which works as expected, goes here: customize.php?autofocus[control]=background_image

Incidentally, there's also a third hidden "Background" link going here: themes.php?page=custom-background

Expected

There should only be one link to the Background section of the Customizer, and it should work.

User report: 2370365-hc

nielslange commented 4 years ago

Thanks for reporting this issue, @tbradsha!

This issue:

a) seems to only affect the theme(s) on WordPress.com, but not on WordPress.org b) seems to only affect old themes, such as Dara and Independent Publisher 2, but not new themes, such as Varia and its child themes

Links within WordPress.org

✅ Customize → /wp-admin/customize.php?theme=themes%2Fdara&return=%2Fwp-admin%2Fthemes.php%3Ftheme%3Dthemes%252Fdara
✅ Widgets → /wp-admin/widgets.php
✅ Menus → /wp-admin/nav-menus.php
✅ Header → /wp-admin/customize.php?autofocus[control]=header_image
✅ Background → /wp-admin/customize.php?autofocus[control]=background_image

Links within WordPress.com

✅ Customize → /wp-admin/customize.php?theme=pub%2Fdara
✅ Widgets → /wp-admin/widgets.php
✅ Menus → /wp-admin/nav-menus.php
❌ Background → /wp-admin/themes.php?page=https://example.wordpress.com/wp-admin/customize.php?autofocus%5Bsection%5D=colors_manager_tool
✅ Header → /wp-admin/customize.php?autofocus[control]=header_image
✅ Background → /wp-admin/customize.php?autofocus[control]=background_image
✅ Mobile → /wp-admin/themes.php?page=mobile-options

WordPress.org
» Dara:

![#1993-org](https://user-images.githubusercontent.com/3323310/81467862-bbb64d80-9205-11ea-9e93-ce98404d241b.png)

WordPress.com
» Dara:

![#1993-com](https://user-images.githubusercontent.com/3323310/81467861-bb1db700-9205-11ea-99f8-43d72ceba9f3.png)

WordPress.com
» Independent Publisher 2:

![#1993-com-independent-publisher-2](https://user-images.githubusercontent.com/3323310/81467860-b8bb5d00-9205-11ea-98c0-478b59819407.png)

cc: @mendezcode, @kjellr or @allancole as I'm sure one of you might have an explanation of this issue.

tbradsha commented 4 years ago

I'd imagine it doesn't affect Varia variants since Background and Header sections aren't available in the Customizer?

nielslange commented 4 years ago

That's a good point, @tbradsha!

Automattic / themes