Automattic / themes

Free WordPress themes made by Automattic for WordPress.org and WordPress.com.
https://themeshaper.com
GNU General Public License v2.0
887 stars 353 forks source link

Sela: Double tap required on menu items on mobile #214

Closed davipontesblog closed 5 years ago

davipontesblog commented 6 years ago

Steps to replicate

  1. Open https://locaellaobjetos.com/ on mobile. I tested it using my Google Pixel 2 Android device, using Google Chrome version 67.0.3396.87.
  2. Tap on Menu
  3. Tap on "Rupert" (as an example. any item behaves the same way)
  4. Tap on "Rupert" again. Menu item loads.

Result

Tapping the menu item on mobile doesn't work, it only places highlights the item it seems. A second tap is required to have the item be opened.

Expected

We expect to be able to open the menu items on mobile with a single tap.

ehti commented 6 years ago

@davipontesblog actually, it looks like the behavior is a bit different here. Not all items require a double tap.

Some menu items work just fine with a single tap for me. Like Rupert's WIP, Erenest's WIP, Needle Felting, Silicone, Online, Shop, About Me, Contact.

It appears, if a menu item has this structure:

Also tested on Sela demo and above theory seems to work there too for me.

Checked using Chrome, Android. However, it doesn't work for @ajaykj on Chrome, only on default browser it works like above.

I checked your Slack convo with @davidakennedy, but don't think it was discussed. So, I'm wondering if this is how Sela is supposed to work, OR is it really a bug?

They reached out again wanting a timeline for a 'fix'.

ehti commented 6 years ago

User also confirmed my theory.

E.g. for Parent -> Child structure, they can single tap the children. While parent requires double tap.

davipontesblog commented 6 years ago

I can confirm the same on my Android phone - thanks @ehti !

davidakennedy commented 5 years ago

Doubling back to this. It works as expected because of the JavaScript loaded it the theme. The double tapping allows users to expect a menu on a touch device where the menu is not fully collapsed under a toggle, like it is on mobile.

Closing this.

csabarakasz commented 2 years ago

Another report of this here: #6710396-hc

The menu is collapsed as default, so the double tap makes no sense. Although it is a retired theme so I am suggesting switching themes.

github-actions[bot] commented 2 years ago

Support References

This comment is automatically generated. Please do not edit it.