search

Automattic / themes

Free WordPress themes made by Automattic for WordPress.org and WordPress.com.
https://themeshaper.com
GNU General Public License v2.0
879 stars 352 forks source link

Premium Theme TheFour - Portfolio Types With Non-Latin Characters Break the Type Filter #4370

Open mxhassani opened 3 years ago

mxhassani commented 3 years ago

Steps to Reproduce

  1. With a Premium plan site
  2. Activate TheFour theme
  3. Go to writing settings and activate Portfolio
  4. Add two types, with at least one containing on its title one of these characters: § | 문 | ى
  5. Populate these types with some projects (Add featured images)
  6. Go to yourdomain.com/portfolio
  7. Try to filter by type

What I expected to happen

Clicking any type will hide projects that are not from said type and show those that are on this type.

What actually happened

If the type name contains only Latin characters, the feature works as expected. If it contains non-Latin characters, the feature doesn't work, nothing changes.

Context

Gif of behavior: https://d.pr/i/oGOIfC zd-4185315

Operating System

macOS

OS Version

10.15.7 (19H1217)

Browser

Firefox

Browser Version

90.0.2

Is this specific to applied theme? If so, what is the theme name?

TheFour

Simple, Atomic or both?

Simple

Console and/or error logs

Uncaught Error: Syntax error, unrecognized expression: .%eb%ac%b8%ed%95%99

Note: .%eb%ac%b8%ed%95%99 is Percent encoding for URIs of the clicked type.

Level of impact

Normal

Reproducibility

Consistent

Other information

I guess converting the parameter back to UTF before passing it to the view update function may fix it.

Nic-Sevic commented 3 years ago

User asking to be updated when resolved: 4185315-zen