Automattic / themes

Free WordPress themes made by Automattic for WordPress.org and WordPress.com.
https://themeshaper.com
GNU General Public License v2.0
902 stars 357 forks source link

Shoreditch Theme: Line Height in Editor no longer being applied correctly #4393

Open rezzap opened 3 years ago

rezzap commented 3 years ago

Steps to Reproduce

  1. Start by activating the Shoreditch theme and create a new post with two three paragraph blocks.
  2. Notice the line height between the paragraphs.
  3. Activate a different theme like Blank Canvas and notice the difference in line height.

What I expected to happen

I expected that the line height would be the same between themes, or at least be visually easy to read.

What actually happened

The line height of the paragraph blocks is quite reduced in Shoreditch and it looks 'squished' making it difficult to edit visually.

Context

4164663-zen

Operating System

macOS

OS Version

10.15.7

Browser

Firefox

Browser Version

90.0 (64-bit)

Is this specific to applied theme? If so, what is the theme name?

Shoreditch

Simple, Atomic or both?

Atomic

Console and/or error logs

No response

Level of impact

Normal

Reproducibility

Consistent

Other information

It looks like this may be coming from the following CSS:

.editor-styles-wrapper p {
    line-height: revert;
}

In other themes this is changed with this:

.editor-styles-wrapper p {
    line-height: var(--wp--typography--line-height, --global--line-height-body);
}

It also adjusts differently if you assign a line-height to the block first instead of leaving it to default.

Image 2021-08-07 at 9 52 00 am

kosiew commented 3 years ago

Hi @rezzap ,

Thanks for reporting this and the detailed steps.

Triaging for developers' further investigation.

IoanaAMuresan commented 3 years ago

Just had another reporting of this - chat transcript: 30800848-hc - same theme (Shoreditch). User explained the text in the editor felt 'crammed' ever since a recent update (a few months ago), with no repercussions on the live site (issue just in the editor, tiring on the eyes when writing often, and aesthetically unpleasing).

Screenshot 2021-10-04 at 15 34 42
livinginbauty commented 3 years ago

We also are having this problem. It makes it difficult to write for hours since the lines are so cramped in the editor. Any chance this can be solved soon? Thanks!

Robertght commented 2 months ago

Another case in 8670410-zen

LE: This is more of a margin issue in my case: https://github.com/Automattic/themes/issues/8061

github-actions[bot] commented 2 months ago

Support References

This comment is automatically generated. Please do not edit it.