Automattic / themes

Free WordPress themes made by Automattic for WordPress.org and WordPress.com.
https://themeshaper.com
GNU General Public License v2.0
907 stars 358 forks source link

Customizer accent color on Atomic sites with Boardwalk theme #5456

Open TPilgs opened 2 years ago

TPilgs commented 2 years ago

Quick summary

Changing accent color on Boardwalk theme on AT sites can make the background of the customizer buttons hard to read or completely unreadable.

Steps to reproduce

  1. Start from an Atomic site
  2. Install the Boardwalk theme
  3. Change "Accent Color" under Customizer > Colors and Backgrounds.
  4. Go to a page editor and check the styles of the buttons on Hover.

In addition, through the Classic editor when you click on Add Media the tab for Upload Files won't show properly

Markup 2022-01-17 at 09 12 09

.

What you expected to happen

Backgrounds and colors of buttons in the editor have contrasting colors to allow them to be readable.

What actually happened

The background of the buttons changes to black making some of them hard to read.

Context

Follow-up ticket: 4693235-zen

Simple, Atomic or both?

Atomic

Theme-specific issue?

Boardwalk

Browser, operating system and other notes

Chrome 97.0.4692.99, Mac Monterrey

Reproducibility

Consistent

Severity

Some (< 50%)

Available workarounds?

No response

Workaround details

No response

Robertght commented 2 years ago

Thank you for reporting this @TPilgs ! It looks quite similar to this one: https://github.com/Automattic/themes/issues/5404

I've noticed this with other themes, but couldn't figure out a pattern yet.

Also, it appears that setting the accent color to default through the Customizer > Colors & Background helps.

I believe this might be more widespread, but testing with Karuna and Dara didn't reveal any weird details yet. cc @jeffikus for further investigation