Automattic / themes

Free WordPress themes made by Automattic for WordPress.org and WordPress.com.
https://themeshaper.com
GNU General Public License v2.0
882 stars 351 forks source link

Byrne Theme: Related Posts not Displaying Categories or Tags #5552

Closed kspilarski closed 2 years ago

kspilarski commented 2 years ago

Quick summary

Byrne theme: In Reading Settings, even "Show context (category or tag)" is selected, related posts do not show categories or themes.

Steps to reproduce

  1. Activate Byrne theme
  2. Go to Settings > Reading
  3. Scroll down to Related Posts and select "Show context (category or tag)"
  4. Save
  5. View a post and check the related posts below.

What you expected to happen

Related posts will show the categories or tags they have.

What actually happened

Posts under related posts do not have categories or tags.

Context

User report: 4752744-zd and self-testing.

User's site and settings:

Screen Shot 2022-02-05 at 5 19 35 PM

Related posts do not have categories or tags below the post title:

Screen Shot 2022-02-05 at 5 22 32 PM

My test site

Using Byrne, related posts are not displayed at all:

Screen Shot 2022-02-05 at 5 45 38 PM

However, using other themes with related posts feature like Rockfield and Canape, the posts and categories are displayed:

Screen Shot 2022-02-05 at 5 44 13 PM Screen Shot 2022-02-05 at 5 42 50 PM

Simple, Atomic or both?

Simple

Theme-specific issue?

Byrne

Browser, operating system and other notes

Firefox 96, macOS 12.2.

Reproducibility

Intermittent

Severity

All

Available workarounds?

Yes, easy to implement

Workaround details

Use Rockfield or Canape theme. Or add related posts block in the post.

Robertght commented 2 years ago

I can confirm both issues appear to be happening on my end as well.

  1. The related posts do not show up on either Simple or Atomic sites
  2. The categories/tags do not show up on the user's site: https://ericarobbin.com/roasted-tomato-and-garlic-soup/

The first one also appears to be related to this issue: https://github.com/Automattic/themes/issues/5264

However, I'm not entirely sure I understand how the related posts section shows up on their site, but not our test ones. As this is a Jetpack feature, is there something we could try to force the section show up? Pinging @jeherve for a second look

jeherve commented 2 years ago

I'm not entirely sure I understand how the related posts section shows up on their site, but not our test ones.

When using a block theme, you would have to add a Related Posts Block to the single post template if you wanted the related posts to be displayed there.

Can you tell what the block settings are on that specific site? Is the block set to display context (categories / tags)? That toggle is not checked by default, so it could be that the site owner did not check it yet?

Robertght commented 2 years ago

When using a block theme, you would have to add a Related Posts Block to the single post template if you wanted the related posts to be displayed there.

This is key. After adding the block and setting the block to show up the context/featured image, the related posts section shows up as expected.

image

Finally, I think we should make this clearer within our docs: https://wordpress.com/support/related-posts/

@donalirl would it be ok to add a piece of information in the doc above to support the users going forward?

Sandkorner commented 2 years ago

Hey.

Not sure if I should post it here, as this is something different, but I guess Kel forgot to mention that there was another issue with comment being left aligned, so that you cannot see them correctly.

For example the same post: https://ericarobbin.com/roasted-tomato-and-garlic-soup/

Screenshot 2022-03-09 at 19 00 16

Let me know if this is already added somewhere as a bug or if I should open a new one. :)

jeherve commented 2 years ago

@Sandkorner That is different indeed, it may be worth opening a new issue for this. Thank you!

Robertght commented 2 years ago

@Sandkorner this one might be similar: https://github.com/Automattic/themes/issues/5622 but I can see that site uses Byrne.

Robertght commented 2 years ago

I have made a request to update the Related posts doc so I'm going to close this one for now.